Skip to content

Ignore parameters causing ValueError when dumping to YAML#19804

Merged
awaelchli merged 7 commits intoLightning-AI:masterfrom
Callidior:patch-1
Jun 6, 2024
Merged

Ignore parameters causing ValueError when dumping to YAML#19804
awaelchli merged 7 commits intoLightning-AI:masterfrom
Callidior:patch-1

Conversation

@Callidior
Copy link
Contributor

@Callidior Callidior commented Apr 23, 2024 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #19730

Unserializable parameters such as nn.Modules or Tensors often fail with a ValueError when calling yaml.dump on them and using PyTorch 2.x.
Lightning already tries to handle this type of error but only catches TypeError so far.
This PR proposes to additionally catch ValueError.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19804.org.readthedocs.build/en/19804/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 23, 2024
@nicolas-mng
Copy link

nicolas-mng commented Apr 24, 2024

Having the same issue, this fix would be useful.

@zhanghaoyue
Copy link

zhanghaoyue commented May 1, 2024 •
edited
Loading

This fix should proceed soon. Otherwise, no way to test multiple models.

@awaelchli awaelchli requested review from lantiga and tchaton as code owners June 6, 2024 18:02
@awaelchli awaelchli added bug Something isn't working community This PR is from the community labels Jun 6, 2024
@awaelchli awaelchli added this to the 2.3 milestone Jun 6, 2024
@codecov
Copy link

codecov bot commented Jun 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53%. Comparing base (a611de0) to head (934f022).
Report is 94 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a611de0) and HEAD (934f022). Click for more details.

HEAD has 173 uploads less than BASE
Flag BASE (a611de0) HEAD (934f022)
python3.10 19 12
cpu 64 22
lightning 39 16
pytest 45 2
examples 8 0
app 8 0
python3.8 12 6
lightning_fabric 10 0
python3.11 20 4
tpu 1 0
gpu 4 2
pytorch2.0 12 11
pytest-full 24 22
pytorch2.1 6 5
pytorch_lightning 10 8
lightning_app 1 0
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19804      +/-   ##
==========================================
- Coverage      84%      53%     -31%     
==========================================
  Files         426      418       -8     
  Lines       35280    35127     -153     
==========================================
- Hits        29616    18708   -10908     
- Misses       5664    16419   +10755

@mergify mergify bot added the ready to be merged PRs ready to be merged label Jun 6, 2024
@awaelchli
Copy link
Contributor

awaelchli commented Jun 6, 2024

Thank you @Callidior, great fix!

@awaelchli awaelchli merged commit 5fa32d9 into Lightning-AI:master Jun 6, 2024
This was referenced Jul 31, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

+1 more reviewer

@awaelchli awaelchli awaelchli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working community This PR is from the community pl Generic label for PyTorch Lightning package ready to be merged PRs ready to be merged

Projects

None yet

Milestone

2.3

Development

Successfully merging this pull request may close these issues.

ValueError: dictionary update sequence element #0 has length 1; 2 is required

5 participants

@Callidior @nicolas-mng @zhanghaoyue @awaelchli @Borda